fix(OUT-3081): preserve QB default class on invoice line items#190
Closed
aschwartz91 wants to merge 2 commits intomasterfrom
Closed
fix(OUT-3081): preserve QB default class on invoice line items#190aschwartz91 wants to merge 2 commits intomasterfrom
aschwartz91 wants to merge 2 commits intomasterfrom
Conversation
…sRef when unset When syncing invoices, we were always including ClassRef in the SalesItemLineDetail payload, even when undefined. This caused QB to clear the item's default class. Now we only include ClassRef when we have an actual value to send, allowing QB to apply its configured default class behavior. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
When items are created or found by name in QB (rather than by mapped ID), we had the qbItem with its ClassRef but weren't passing it through to the invoice line item payload. QB's API does not auto-apply an item's default class to invoice line items, so we must explicitly forward it. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
aschwartz91
changed the title
Collaborator
SandipBajracharya
left a comment
SandipBajracharya
left a comment
There was a problem hiding this comment.
The implementation lgtm. Since the deployment is failing in vercel, deployed same implementation from another branch. PR here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClassRefwas always included in theSalesItemLineDetailpayload, even whenundefined. This caused QuickBooks to clear the item's default class to blank....(itemRef.classRef && { ClassRef: itemRef.classRef })) soClassRefis only included when we have an actual value. This allows QB to apply its configured default class behavior on items.Test plan
ClassRefis sent and behavior is unchangedClassRef— verify the class is correctly forwarded🤖 Generated with Claude Code